Fix varz_jetstream_meta_leader reports more than one leader #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -231,6 +231,7 @@ func (nc *NATSCollector) collectStatsFromRequests( | |||
| case float64: // json only has floats | |||
| m.WithLabelValues(id).Set(v) | |||
| case string: | |||
| m.Reset() | |||
|
After thinking about this issue, I believe the same thing will happen with float values because they contain dynamic labels such as "meta_leader". For example, for the metric I didn't attempt to reproduce it, but if you can reproduce, maybe it should just reset all gauges before setting the new values. This way old labels will be clean up. The problem is that this approach won't work for counters. Maybe you should think about removing dynamic labels from metrics. You can create a single gauge to hold all the values and then merge with other metrics if you need to extend the information. |
variadico
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #179