(#691) Add --offline to stream and consumer find commands#1455
Closed
ploubser wants to merge 1 commit intonats-io:mainfrom
Closed
(#691) Add --offline to stream and consumer find commands#1455ploubser wants to merge 1 commit intonats-io:mainfrom
ploubser wants to merge 1 commit intonats-io:mainfrom
Conversation
Collaborator
Author
|
Tests are dependent on nats-io/nats-server#7158 being merged. |
Signed-off-by: Pieter Loubser <ploubser@gmail.com>
ripienaar
reviewed
Aug 12, 2025
| return err | ||
| } | ||
|
|
||
| if c.offline { |
Collaborator
There was a problem hiding this comment.
nah I think this should become a option into the query package like the others above?
Collaborator
Author
There was a problem hiding this comment.
Don't think the option is defined in JSM. I'll look at adding it.
Collaborator
Author
|
Closing this for now as the server work is still a WIP. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.