Add support for message schedules#963
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for message scheduling in JetStream by introducing the AllowMsgSchedules property to the StreamConfig class, implementing the new feature described in ADR-51.
- Added
AllowMsgSchedulesboolean property toStreamConfigwith proper JSON serialization attributes - Created comprehensive test coverage to verify property setting, persistence, and error handling when disabling schedules
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/NATS.Client.JetStream/Models/StreamConfig.cs | Added AllowMsgSchedules property with JSON serialization configuration |
| tests/NATS.Client.JetStream.Tests/ManageStreamTest.cs | Added test method and required import to verify message scheduling functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
# Conflicts: # src/NATS.Client.JetStream/Models/StreamConfig.cs # tests/NATS.Client.JetStream.Tests/ManageStreamTest.cs
mtmk
added a commit
that referenced
this pull request
Oct 1, 2025
Merged
mtmk
added a commit
that referenced
this pull request
Oct 1, 2025
This was referenced Mar 2, 2026
This was referenced Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for the new
AllowMsgSchedulesproperty in the JetStreamStreamConfig, enabling the scheduling of messages as described in ADR-51. It also adds a corresponding test to verify correct behavior when creating and updating streams with this property.JetStream StreamConfig enhancements:
AllowMsgSchedulesboolean property to theStreamConfigclass, allowing message scheduling to be enabled or disabled for streams.Testing improvements:
AllowMsgSchedules_property_should_be_set_on_stream, which verifies that theAllowMsgSchedulesproperty is correctly set, persisted, and enforces that disabling it after enabling returns the expected error.NATS.Client.TestUtilitiesinManageStreamTest.csto support the new test.