Fix CommandWriter.cs dispose#926
Merged
Merged
Conversation
This was referenced Aug 15, 2025
Merged
Merged
mtmk
added a commit
that referenced
this pull request
Aug 21, 2025
fess9999
pushed a commit
to TouchPlusIE/nats.net
that referenced
this pull request
Sep 10, 2025
fess9999
pushed a commit
to TouchPlusIE/nats.net
that referenced
this pull request
Sep 10, 2025
* Fix pending message reset logic in NatsJSConsume (nats-io#930) * Fix CommandWriter.cs dispose (nats-io#926)
Merged
This was referenced Mar 2, 2026
This was referenced Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
DisposeAsyncmethod inCommandWriter.csto ensure that both_ctsand_ctsReadercancellation tokens are properly canceled during disposal, improving resource cleanup and preventing potential hangs.