Add RequestTimeout option to NatsJSOpts for request operations#918
Conversation
|
sign-off check isn't working because when checked out I can't see the signature 😕 .. even though github seems to be happy saying it's 'verified'. as long as github is happy we're fine. we can ignore the failing action. |
mtmk
left a comment
There was a problem hiding this comment.
LGTM thanks @johnweldon
(minor nit above)
Strange: It's signed with an SSH key |
ah, so that's your local git log I presume. When I clone I see I must be doing something wrong verifying SSH signatures. edit: my bad. didn't have |
|
ah, yes. it was a problem with the sign-off check workflow. thanks for the fix @johnweldon! |
…ection NatsOpts value
The previous implementation used the defaults from the connections NatsOpts RequestTimeout for JetStream specific request/reply operations.
This change allows setting a separate default value for JetStream operations from the core NatsOpts default.