Skip to content

Add RequestTimeout option to NatsJSOpts for request operations#918

Merged
mtmk merged 3 commits into
nats-io:mainfrom
johnweldon:jw4/jsopts-request-timeout
Jul 26, 2025
Merged

Add RequestTimeout option to NatsJSOpts for request operations#918
mtmk merged 3 commits into
nats-io:mainfrom
johnweldon:jw4/jsopts-request-timeout

Conversation

@johnweldon

Copy link
Copy Markdown
Member

The previous implementation used the defaults from the connections NatsOpts RequestTimeout for JetStream specific request/reply operations.

This change allows setting a separate default value for JetStream operations from the core NatsOpts default.

Comment thread src/NATS.Client.JetStream/NatsJSOpts.cs Outdated
@mtmk

mtmk commented Jul 25, 2025

Copy link
Copy Markdown
Member

sign-off check isn't working because when checked out I can't see the signature 😕 .. even though github seems to be happy saying it's 'verified'. as long as github is happy we're fine. we can ignore the failing action.

@mtmk mtmk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @johnweldon

(minor nit above)

@johnweldon

Copy link
Copy Markdown
Member Author

sign-off check isn't working because when checked out I can't see the signature 😕 .. even though github seems to be happy saying it's 'verified'. as long as github is happy we're fine. we can ignore the failing action.

Strange: It's signed with an SSH key

commit 0be4bcad40677d8ed27964dd5b4d86fd87d8a07a
tree 6a267b939d34bd47176c31f6abd6d50c3eaa1f42
parent 29c5fb6de4298e0841127e9a3297733199bd15d3
author John Weldon <jweldon@nats.io> 1753466771 -0700
committer John Weldon <jweldon@nats.io> 1753466771 -0700
gpgsig -----BEGIN SSH SIGNATURE-----
 U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgoF8y/bAz3yCOkum4kJ+QgVxyuK
 qRqArIXSzcAJAQ5j8AAAADZ2l0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5
 AAAAQARYT7y0aUXgeMD9aZh+fT2HtwWpu7YkX5G2KPwbDxI2MGqBBsHq7/KOegQqzvTtla
 Kp/YsTO8JZ5eQ3s3YbUAc=
 -----END SSH SIGNATURE-----
 
    Add RequestTimeout option to NatsJSOpts for request operations

@mtmk

mtmk commented Jul 25, 2025

Copy link
Copy Markdown
Member

sign-off check isn't working because when checked out I can't see the signature 😕 .. even though github seems to be happy saying it's 'verified'. as long as github is happy we're fine. we can ignore the failing action.

Strange: It's signed with an SSH key

commit 0be4bcad40677d8ed27964dd5b4d86fd87d8a07a
tree 6a267b939d34bd47176c31f6abd6d50c3eaa1f42
parent 29c5fb6de4298e0841127e9a3297733199bd15d3
author John Weldon <jweldon@nats.io> 1753466771 -0700
committer John Weldon <jweldon@nats.io> 1753466771 -0700
gpgsig -----BEGIN SSH SIGNATURE-----
 U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgoF8y/bAz3yCOkum4kJ+QgVxyuK
 qRqArIXSzcAJAQ5j8AAAADZ2l0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5
 AAAAQARYT7y0aUXgeMD9aZh+fT2HtwWpu7YkX5G2KPwbDxI2MGqBBsHq7/KOegQqzvTtla
 Kp/YsTO8JZ5eQ3s3YbUAc=
 -----END SSH SIGNATURE-----
 
    Add RequestTimeout option to NatsJSOpts for request operations

ah, so that's your local git log I presume. When I clone I see No signature:

➜  nats.net git:(jw4/jsopts-request-timeout) git log --show-signature | head
error: gpg.ssh.allowedSignersFile needs to be configured and exist for ssh signature verification
commit 0be4bcad40677d8ed27964dd5b4d86fd87d8a07a
No signature
Author: John Weldon <jweldon@nats.io>
Date:   Fri Jul 25 11:06:11 2025 -0700

    Add RequestTimeout option to NatsJSOpts for request operations

I must be doing something wrong verifying SSH signatures.

edit: my bad. didn't have gpg.ssh.allowedSignersFile in my git config locally.

@mtmk

mtmk commented Jul 25, 2025

Copy link
Copy Markdown
Member

ah, yes. it was a problem with the sign-off check workflow. thanks for the fix @johnweldon!

@mtmk
mtmk merged commit b0d6142 into nats-io:main Jul 26, 2025
18 checks passed
mtmk added a commit that referenced this pull request Aug 1, 2025
* Add watcher cancellation handling (#881)
* Fix pull request exception handling (#919)
* Add RequestTimeout option to NatsJSOpts for request operations (#918)
@mtmk mtmk mentioned this pull request Aug 1, 2025
mtmk added a commit that referenced this pull request Aug 1, 2025
* Add watcher cancellation handling (#881)
* Fix pull request exception handling (#919)
* Add RequestTimeout option to NatsJSOpts for request operations (#918)
@mtmk mtmk mentioned this pull request Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants