Skip to content

Fix inbox collection was modified exception #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mtmk merged 1 commit into from
Jun 24, 2025
Merged

Fix inbox collection was modified exception #885

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/NATS.Client.Core/Internal/InboxSub.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,13 +128,24 @@ public async ValueTask ReceivedAsync(string subject, string? replyTo, ReadOnlySe
}

#if NETSTANDARD2_0
foreach (var weakReference in subTable)
WeakReference<NatsSubBase>[] weakReferences;
int subscriptionCount;
lock (subTable)
Comment thread
mtmk marked this conversation as resolved.
{
if (weakReference.TryGetTarget(out var sub))
subscriptionCount = subTable.Count;
weakReferences = ArrayPool<WeakReference<NatsSubBase>>.Shared.Rent(subscriptionCount);
subTable.CopyTo(weakReferences, 0);
}

for (var i = 0; i < subscriptionCount; i++)
{
if (weakReferences[i].TryGetTarget(out var sub))
{
await sub.ReceiveAsync(subject, replyTo, headersBuffer, payloadBuffer).ConfigureAwait(false);
}
}

ArrayPool<WeakReference<NatsSubBase>>.Shared.Return(weakReferences);
Comment thread
mtmk marked this conversation as resolved.
#else
foreach (var (sub, _) in subTable)
{
Expand Down
Loading