Add sign-off and commit signature checks to CI workflow#873
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mtmk
marked this pull request as draft
May 25, 2025 20:09
mtmk
force-pushed
the
verify-pr-commits
branch
2 times, most recently
from
May 27, 2025 13:37
41af9cd to
a193e01
Compare
Member
Author
|
|
This introduces a new workflow ensuring all commits are GPG signed.
Member
Author
…in permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
mtmk
marked this pull request as ready for review
May 27, 2025 15:05
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds a new CI workflow that checks for commit sign-offs to help inform contributors that their commits require signatures. The key changes include updating the NATS.Net.sln file to include the new signoffs.yml workflow and introducing the signoffs.yml GitHub Actions workflow that validates commit signatures.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| NATS.Net.sln | Added reference to the signoffs workflow configuration |
| .github/workflows/signoffs.yml | New workflow that iterates over commits to check for valid signatures |
| @@ -0,0 +1,27 @@ | |||
| name: Sign-offs | |||
There was a problem hiding this comment.
A hidden Byte Order Mark (BOM) appears at the beginning of this file; consider saving it as UTF-8 without BOM to avoid potential YAML parsing issues.
Suggested change
| name: Sign-offs | |
| name: Sign-offs |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This was referenced Jul 28, 2025
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick check to warn new contributors they need to sign commits.