Cleanup Csproj#869
Merged
Merged
Conversation
Member
|
quick peek looks good. thanks @thompson-tomo. will have a proper look soon just to double check |
Contributor
Author
|
No worries and the dotnet format issue should be resolved now. |
Contributor
Author
|
Flaky test again? |
thompson-tomo
force-pushed
the
CsprojCleanup
branch
2 times, most recently
from
May 25, 2025 02:18
c5f3d38 to
991347e
Compare
Signed-off-by: James Thompson <thompson.tomo@outlook.com>
Signed-off-by: James Thompson <thompson.tomo@outlook.com>
thompson-tomo
force-pushed
the
CsprojCleanup
branch
from
May 25, 2025 14:33
991347e to
69aba40
Compare
mtmk
approved these changes
May 29, 2025
mtmk
left a comment
mtmk
left a comment
Member
There was a problem hiding this comment.
LGTM thanks @thompson-tomo cleaned up the proj files really nicely. sorry for the delay.
Merged
mtmk
added a commit
that referenced
this pull request
Jun 30, 2025
This was referenced Jul 28, 2025
Closed
Merged
This was referenced Mar 2, 2026
This was referenced Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase usage of directory.build.props to reduce replication of properties across files. Have also move to suppression in code rather than global,