Skip to content

Clean up reconnect logs #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mtmk merged 4 commits into from
May 2, 2025
Merged

Clean up reconnect logs #843

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
47db614
Clean up reconnect logs
mtmk May 1, 2025
4f65437
Add code comment
mtmk May 1, 2025
c670767
Add reconnect exit log
mtmk May 1, 2025
861e13f
Typo
mtmk May 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/NATS.Client.Core/NatsConnection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,15 +756,11 @@ private async void ReconnectLoop()
// which in turn would crash the application.
// (e.g. we've seen this with EventLog provider on Windows)
}

return;
}

// the reconnect loop should never get here, since everything
// is either an early return or stays in the loop
try
{
_logger.LogError(NatsLogEvents.Connection, "Retry loop stopped and connection state is invalid [{ReconnectCount}]", reconnectCount);

@mtmk mtmk May 1, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is logged on a clean reconnect which isn't an error case

_logger.LogDebug(NatsLogEvents.Connection, "Reconnect loop stopped [{ReconnectCount}]", reconnectCount);

@mtmk mtmk May 1, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

helpful for debugging reconnect issues

}
catch
{
Expand Down Expand Up @@ -946,6 +942,10 @@ private async void StartPingTimer(CancellationToken cancellationToken)
await periodicTimer.WaitForNextTickAsync(cancellationToken).ConfigureAwait(false);
}
}
catch (OperationCanceledException)
{
// Cancelling is part of a normal reconnect operation, so we don't need to log this
}
catch (Exception e)
{
if (!IsDisposed)
Expand Down