Make NatsJSConstants public#825
Merged
Merged
Conversation
mtmk
reviewed
Apr 13, 2025
Member
|
sorry @aradalvand simple change but taking too much of your time. we need all the commits signed which means you'd need to force push. thanks!
|
Contributor
Author
|
@mtmk No worries! |
Member
I mentioned force push because you need to discard the unsigned commit and create a new signed commit with the same change. Actually it looks like your first commit was signed. it's the second one stopping the merge.
|
Contributor
Author
|
Learned something today, lol! |
mtmk
added a commit
that referenced
this pull request
Apr 16, 2025
* Stopped testing with net6.0 (#821) * Update JetStream models (#832) * Add direct request-reply (#829) * Socket Connection Factory (#828) * Fix proxy with TLS scenario with SocketConnectionFactory (#826) * Make NatsJSConstants public (#825) * Use Stopwatch in PingCommand for more precise timing (#827) * Fix netstandard bugs and tidy up tests (#817)
Merged
mtmk
added a commit
that referenced
this pull request
Apr 16, 2025
* Stopped testing with net6.0 (#821) * Update JetStream models (#832) * Add direct request-reply (#829) * Socket Connection Factory (#828) * Fix proxy with TLS scenario with SocketConnectionFactory (#826) * Make NatsJSConstants public (#825) * Use Stopwatch in PingCommand for more precise timing (#827) * Fix netstandard bugs and tidy up tests (#817)
This was referenced Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #824