Make NatsMsg<T>.Build Public#819
Merged
Merged
Conversation
mtmk
approved these changes
Apr 10, 2025
mtmk
left a comment
mtmk
left a comment
Member
There was a problem hiding this comment.
LGTM thanks @darkwatchuk
Added docs with a remark that the API is internal to give notice to application developers to be careful about using it if they are more concern about future release stability since i feel we should have the freedom to change this without much concern.
mtmk
added a commit
that referenced
this pull request
Apr 10, 2025
* Make NatsMsg<T>.Build Public (#819) * Fixed build badge
Merged
mtmk
added a commit
that referenced
this pull request
Apr 10, 2025
* Release 2.5.15 * Make NatsMsg<T>.Build Public (#819) * Fixed build badge * Update build badge
This was referenced Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is just to make NatsMsg.Build public , currently internal.
This allows for creation of INatsSub implementations from outside of the library.
Thanks!