Skip to content

Added Additional Try Commands to KVStore#728

Merged
mtmk merged 5 commits into
nats-io:mainfrom
darkwatchuk:KV-Try-Commands
Jan 29, 2025
Merged

Added Additional Try Commands to KVStore#728
mtmk merged 5 commits into
nats-io:mainfrom
darkwatchuk:KV-Try-Commands

Conversation

@darkwatchuk

@darkwatchuk darkwatchuk commented Jan 27, 2025

Copy link
Copy Markdown
Collaborator

Added the following commands to KVStore ;

  • TryCreateAsync
  • TryUpdateAsync
  • TryDeleteAsync
  • TryPurgeAsync

Comment thread tests/NATS.Client.KeyValueStore.Tests/KeyValueStoreTest.cs
Comment thread src/NATS.Client.KeyValueStore/NatsKVStore.cs Outdated
Comment thread src/NATS.Client.KeyValueStore/NatsKVStore.cs Outdated
Comment thread src/NATS.Client.KeyValueStore/NatsKVStore.cs Outdated
Comment thread src/NATS.Client.KeyValueStore/NatsKVStore.cs Outdated
KV : Changed ValidateKey to TryValidateKey
KV : Exposed TryValidateKey as static NatsKVStore.IsValidKey
KV : Changed TryXXX to use TryValidateKey, key exceptions are no longer raised here.
KV : Changed TryXXX to use JSContext.TryPublishAsync
JSContext : Added TryPublishAsync
KV Tests : Changed Try_* tests to use TryPutAsync rather than TryPut
KV Tests : Added Several Key tests
Comment thread src/NATS.Client.KeyValueStore/NatsKVStore.cs Outdated
Comment thread src/NATS.Client.JetStream/NatsJSContext.cs Outdated
Comment thread src/NATS.Client.Core/NatsResult.cs Outdated
Comment thread src/NATS.Client.KeyValueStore/NatsKVStore.cs Outdated
Comment thread src/NATS.Client.KeyValueStore/NatsKVStore.cs Outdated
Comment thread src/NATS.Client.KeyValueStore/NatsKVStore.cs Outdated
Comment thread src/NATS.Client.KeyValueStore/NatsKVStore.cs Outdated
Comment thread src/NATS.Client.KeyValueStore/NatsKVStore.cs Outdated
Comment thread src/NATS.Client.JetStream/NatsJSContext.cs Outdated

@mtmk mtmk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @darkwatchuk

@mtmk
mtmk merged commit daef76d into nats-io:main Jan 29, 2025
mtmk added a commit that referenced this pull request Jan 29, 2025
* Added Additional Try Commands to KVStore (#728)
@mtmk mtmk mentioned this pull request Jan 29, 2025
mtmk added a commit that referenced this pull request Jan 29, 2025
* Release 2.5.8-preview.1

* Added Additional Try Commands to KVStore (#728)

* Disable obsolete warning in test
mtmk added a commit that referenced this pull request Feb 11, 2025
* Add service use queue group option (#734)
* Added Additional Try Commands to KVStore (#728)
@mtmk mtmk mentioned this pull request Feb 11, 2025
mtmk added a commit that referenced this pull request Feb 11, 2025
* Add service use queue group option (#734)
* Added Additional Try Commands to KVStore (#728)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add versions of KV commands that don't throw exceptions?

2 participants