Initial implementation of per-key-TTL for KV#703
Merged
Conversation
stebet
force-pushed
the
message-ttl
branch
3 times, most recently
from
January 8, 2025 16:15
74d3cf9 to
d234060
Compare
Member
|
we're hoping to merge this into server 2.11 branch before server release #733 |
|
Can't wait for per-key TTL, it will allow usage of NATS in FusionCache too. Thanks for all the hard work! |
… tests for errors when message TTL is disabled
…ts. Those implementing the interface will still need to make changes.
stebet
marked this pull request as ready for review
February 6, 2025 16:40
mtmk
approved these changes
Feb 7, 2025
mtmk
left a comment
Member
There was a problem hiding this comment.
LGTM thanks @stebet
There are still details to be worked out e.g. around SubjectDeleteMarkerTTL but this PR introduces support for per-message/key TTL feature for new server 2.11 soon to be released. We can have follow up PRs into the server-2.11-features branch when we have more implementation details available.
mtmk
added a commit
that referenced
this pull request
Feb 27, 2025
* Initial implementation of per-key-TTL for KV (#703)
Merged
mtmk
added a commit
that referenced
this pull request
Feb 27, 2025
* Initial implementation of per-key-TTL for KV (#703)
mtmk
added a commit
that referenced
this pull request
Apr 25, 2025
* Update README.md * Initial implementation of per-key-TTL for KV (#703) * Initial implementation of per-key-TTL for KV * Skip TTL tests for nats versions older than 2.11 * Adding support for SubjectDeleteMarkerTTL in the Stream config. Added tests for errors when message TTL is disabled * Fixing tests after rebase * Updating the interface to not break backwards-compatibility for clients. Those implementing the interface will still need to make changes. * Add NATS v2.11 requirement notes for TTL-related features (#751) Updated XML comments and remarks to specify that TTL and delete marker features require NATS server v2.11 or later. This ensures clarity on version-specific functionality for developers. * Enable workflows for release/* branches This change updates the GitHub Actions release workflow to trigger on pushes to branches matching the release/* pattern. This ensures release-specific branches are included in the automation process. * Release 2.6.0-preview.1 (#753) * Initial implementation of per-key-TTL for KV (#703) * Add priority group options (overflow) (#743) * Add priority group options * Add support for priority groups in pull consumers This commit introduces priority group configuration for JetStream pull consumers. Implements behavior for `NextAsync`, `FetchAsync`, and `ConsumeAsync` with priority group settings. Unsupported cases like multiple groups and certain priority policies are handled with exceptions. * Fix format * Release 2.6.0-preview.2 (#754) * Add priority group options (overflow) (#743) * Release 2.6.0-preview.3 (#775) Merge from main 2.5.10. * Add KV marker reason check (#787) * Add KV marker reason check * Add KV watcher support for marker reason * Add test for SubjectDeleteMarkerTTL * Release 2.6.0-preview.4 (#816) * Add KV marker reason check (#787) * Fix tests * Update KV per key TTL (#831) * Update KV per key TTL Based on adr-48 * Fix format * Release 2.6.0-preview.5 (#838) * Update KV per key TTL (#831) --------- Co-authored-by: Stefán Jökull Sigurðarson <stefanjokull@hotmail.com>
mtmk
added a commit
that referenced
this pull request
Apr 25, 2025
Merged
mtmk
added a commit
that referenced
this pull request
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
AllowMsgTTLflag for KV streamsTimestamp ttloptional parameter to thePutAsync<T>method onINatsKVStoreTODO:
CreateAsync/UpdateAsyncAPI methodssee also ADR-43