Add flags to NatsMsg and JetStream Request#652
Merged
Merged
Conversation
to11mtm
reviewed
Oct 12, 2024
to11mtm
reviewed
Oct 12, 2024
to11mtm
left a comment
to11mtm
left a comment
Collaborator
There was a problem hiding this comment.
Just some comments/etc.
Reordered error checks in `NatsJSContext.cs` to prioritize handling `HasNoResponders` and `null` data conditions early. Modified flag checks in `NatsMsg.cs` for `IsEmpty` and `HasNoResponders` by directly using bitwise operations instead of enum comparisons.
to11mtm
reviewed
Oct 17, 2024
mtmk
marked this pull request as ready for review
November 21, 2024 12:24
mtmk
added a commit
that referenced
this pull request
Dec 10, 2024
Merged
mtmk
added a commit
that referenced
this pull request
Dec 10, 2024
This was referenced Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of preparing to reduce exception usage as stated in #581.
Note that a similar attempt was made in #275 but due to NatsMsg struct size getting larger it wasn't merged. With this PR we're using the message size fields left most two bits to set the flags relying on the fact a 30-bit field would still be large enough to hold message size int.
JetStream request changed to handle API error responses without throwing exceptions.