Skip to content

Adds type-forwarders NET 5.0+#641

Merged
mtmk merged 1 commit into
nats-io:mainfrom
VaticanUK:main
Oct 1, 2024
Merged

Adds type-forwarders NET 5.0+#641
mtmk merged 1 commit into
nats-io:mainfrom
VaticanUK:main

Conversation

@VaticanUK

Copy link
Copy Markdown
Contributor

Adds missing type forwarders to fix MissingMethodExceptions when this library is consumed by a .NET standard library, which is then consumed by a > .NET 5 app

Resolves #640

@mtmk mtmk self-assigned this Sep 30, 2024
Comment thread src/NATS.Client.Core/Internal/netstandard.cs Outdated

@mtmk mtmk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @VaticanUK

@mtmk

mtmk commented Sep 30, 2024

Copy link
Copy Markdown
Member

ouch! sorry @VaticanUK forgot to mention. Could you rebase and sign your commit please? (You will need to force push and don't worry about my commit, that can be absorbed as well) Otherwise I can't merge since it's a CNCF requirement and we have a rule for it in repo settings.

@VaticanUK
VaticanUK force-pushed the main branch 2 times, most recently from 720fe3c to 1cb294e Compare September 30, 2024 21:39
@VaticanUK

Copy link
Copy Markdown
Contributor Author

Ok, got there in the end :)

@mtmk
mtmk merged commit 06156f9 into nats-io:main Oct 1, 2024
mtmk added a commit that referenced this pull request Oct 1, 2024
* Added Domain support for stream mirroring and sourcing and KV full support for the same. (#631)
* Adds type-forwarders NET 5.0+ (#641)
* Run core tests on Windows and test run stability (#464)
* Add JetStream NATS Client Extensions (#598)
@mtmk mtmk mentioned this pull request Oct 1, 2024
mtmk added a commit that referenced this pull request Oct 1, 2024
* Added Domain support for stream mirroring and sourcing and KV full support for the same. (#631)
* Adds type-forwarders NET 5.0+ (#641)
* Run core tests on Windows and test run stability (#464)
* Add JetStream NATS Client Extensions (#598)
mtmk added a commit that referenced this pull request Oct 9, 2024
* Add placement configuration to key-value and object store (#650)
* Bump System.Text.Json from 8.0.4 to 8.0.5 in /src/NATS.Client.Core (#649)
* Add other client extensions (#637)
* Add Domain support for stream mirroring and sourcing and KV full support for the same. (#631)
* Add type-forwarders NET 5.0+ (#641)
* Add JetStream NATS Client Extensions (#598)
@mtmk mtmk mentioned this pull request Oct 9, 2024
mtmk added a commit that referenced this pull request Oct 9, 2024
* Add placement configuration to key-value and object store (#650)
* Bump System.Text.Json from 8.0.4 to 8.0.5 in /src/NATS.Client.Core (#649)
* Add other client extensions (#637)
* Add Domain support for stream mirroring and sourcing and KV full support for the same. (#631)
* Add type-forwarders NET 5.0+ (#641)
* Add JetStream NATS Client Extensions (#598)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing Type-Forwarders

2 participants