Skip to content

Add v2.12 to test matrix, drop v2.10#1136

Merged
mtmk merged 1 commit into
mainfrom
ci-bump-server-matrix-2.12
May 13, 2026
Merged

Add v2.12 to test matrix, drop v2.10#1136
mtmk merged 1 commit into
mainfrom
ci-bump-server-matrix-2.12

Conversation

@mtmk

@mtmk mtmk commented May 13, 2026

Copy link
Copy Markdown
Member

Bump nats-server test matrix in the Linux, Linux Core, Windows, and Perf workflows to run against v2.12 and drop v2.10.

@synadia-claude-reviewer

synadia-claude-reviewer Bot commented May 13, 2026

Copy link
Copy Markdown
Contributor

Claude finished @mtmk's task in 38s —— View job


PR Review

  • Gather PR diff and context
  • Review workflow changes for correctness
  • Post review summary

Verdict: LGTM — straightforward, consistent matrix bump across all 4 workflows.

The change correctly replaces v2.10 with v2.12 in each file. A few observations:

  • test_linux.yml, test_linux_core.yml, and test_windows.yml now test against v2.11, v2.12, latest, and main — retaining the previous 4-entry pattern.
  • perf.yml tests against v2.12, latest, and main. It never included v2.11, so skipping from v2.10 directly to v2.12 in that workflow is consistent with its historical pattern (smaller matrix by design).

No correctness, security, or performance concerns.

@piotrpio piotrpio left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtmk
mtmk merged commit d5c9d04 into main May 13, 2026
33 of 35 checks passed
@mtmk
mtmk deleted the ci-bump-server-matrix-2.12 branch May 13, 2026 09:49
This was referenced May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants