Skip to content

Fix 2.6/2.7 ABI for serializer interfaces#1032

Merged
mtmk merged 1 commit into
mainfrom
fix-abi-compat
Jan 8, 2026
Merged

Fix 2.6/2.7 ABI for serializer interfaces#1032
mtmk merged 1 commit into
mainfrom
fix-abi-compat

Conversation

@mtmk

@mtmk mtmk commented Jan 6, 2026

Copy link
Copy Markdown
Member

Fixes #1029

@mtmk
mtmk requested review from caleblloyd and scottf January 6, 2026 11:35

@caleblloyd caleblloyd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good. A future improvement to the test could be using something like Microsoft.DotNet.ApiCompat.Tool to check compat

@scottf scottf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtmk
mtmk merged commit 392cee9 into main Jan 8, 2026
21 checks passed
@mtmk
mtmk deleted the fix-abi-compat branch January 8, 2026 11:02
mtmk added a commit that referenced this pull request Jan 8, 2026
* Fix OTel INatsJSMsg extension (#1031)
* Fix 2.6/2.7 ABI for serializer interfaces (#1032)
@mtmk mtmk mentioned this pull request Jan 8, 2026
mtmk added a commit that referenced this pull request Jan 8, 2026
* Fix OTel INatsJSMsg extension (#1031)
* Fix 2.6/2.7 ABI for serializer interfaces (#1032)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2.7.0 INatsSerialize ABI break in INatsSerialize

3 participants