Add Timeout to Object Get Disposal#1014
Merged
Merged
Conversation
mtmk
commented
Dec 11, 2025
mtmk
commented
Member
- Potential fix for ObjectStore.GetAsync stuck for hours #1013
| _msgChannel.Writer.TryComplete(); | ||
|
|
||
| await _context.DeleteConsumerAsync(_stream, Consumer, _cancellationToken); | ||
| using var cts = new CancellationTokenSource(_opts.CleanupTimeout); |
Contributor
There was a problem hiding this comment.
I think combining both, timeout and original token, would be even better:
using var cts = CancellationTokenSource.CreateLinkedTokenSource(_cancellationToken);
cts.CancelAfter(_opts.CleanupTimeout);
Member
Author
There was a problem hiding this comment.
fair point. I can link them.
| _msgChannel.Writer.TryComplete(); | ||
|
|
||
| using var cts = new CancellationTokenSource(_opts.CleanupTimeout); | ||
| using var ctsLinked = CancellationTokenSource.CreateLinkedTokenSource(cts.Token, _cancellationToken); |
Contributor
There was a problem hiding this comment.
Don't want to be preachy about it, but I cannot resist ;-)
This approach:
using var cts = CancellationTokenSource.CreateLinkedTokenSource(_cancellationToken);
cts.CancelAfter(_opts.CleanupTimeout);creates one CancellationTokenSource and one (internal) Timer.
While this one:
using var cts = new CancellationTokenSource(_opts.CleanupTimeout);
using var ctsLinked = CancellationTokenSource.CreateLinkedTokenSource(cts.Token, _cancellationToken);creates two CancellationTokenSources and one (internal) Timer.
The first one is just a little bit lighter resource-wise.
Also one less implicit finally.
mtmk
marked this pull request as ready for review
December 12, 2025 12:10
Merged
mtmk
added a commit
that referenced
this pull request
Dec 17, 2025
This was referenced Mar 2, 2026
This was referenced Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.