Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'Promise<never>' to ConsumerCallbackFn #200

Merged
merged 1 commit into from
Feb 1, 2025
Merged

Add 'Promise<never>' to ConsumerCallbackFn #200

merged 1 commit into from
Feb 1, 2025

Conversation

atbe
Copy link
Contributor

@atbe atbe commented Jan 31, 2025 •
edited
Loading

This PR changes the callback type on ConsumeOptions to allow linters to explicitly call out the fact that the callback parameter will not be await'd and is therefore an error if an async method is passed in.

@aricart aricart merged commit ef2fd7b into nats-io:main Feb 1, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aricart aricart aricart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atbe @aricart