internal(jetstream): direct consumer #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aricart
force-pushed
the
direct-oc
branch
2 times, most recently
from
8881dd5 to
94875c2
Compare
Signed-off-by: Alberto Ricart <[email protected]>
Removed the unnecessary error parameter from the callback function in the get method to streamline the code. Corrected the handling of errors by ensuring the check is done on the 'done' object directly, improving code clarity and maintainability. Signed-off-by: Alberto Ricart <[email protected]>
Implement 'consume'. Update the direct consumer implementation to include status notifications, debug capability, and corrections on DirectMessage to pending messages to account for the end-of-messages signal from the server. Signed-off-by: Alberto Ricart <[email protected]>
Signed-off-by: Alberto Ricart <[email protected]>
Signed-off-by: Alberto Ricart <[email protected]>
Introduce server version checks for direct API functionality to ensure compatibility with server requirements. Enhance `direct_consumer_test` with additional debug and status tracking logic. These changes improve test robustness and developer insight during testing. Fixed an issue where underling error was being thrown instead of rejecting. Signed-off-by: Alberto Ricart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
internal implementation for a direct consumer.