FEAT: services api queue option empty string means no queue, metadata is read-only #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…means that the service/endpoint/group will not be in a queue. Clients that specifically assign queue names should experience no changes. And clients that didn't specify a value for the property (so the property was undefined) should also not experience a change and should see their service/endpoint/group use the `q` group. If explicetly set to an empty string ``, the service will NOT be part of a queue. breaking(services): the metadata configuration specified when creating the service is now stored read-only, any type of edit on the internal copy will result in a `TypeError` as the metdata object is frozen. Signed-off-by: Alberto Ricart <[email protected]>
|
@aricart can you explain the behavior when queue is set to an empty string? Does this mean that all instances of the service will get the request and respond then the client will only take the first answer? |
|
See https://github.com/nats-io/nats.js/tree/main/core#queue-groups Empty is no queue group. Having a queue is what you want... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
breaking (services): the queue property now, if set to an empty string, means that the service/endpoint/group will not be in a queue. Clients that specifically assign queue names should experience no changes. Clients that didn't specify a value for the property (so the property was undefined) should also not experience a change and should see their service/endpoint/group use the
qgroup. If explicitly set to an empty string ``, the service will NOT be part of a queue.breaking (services): The metadata configuration specified when creating the service is now stored read-only. Any edit on the internal copy will result in a
TypeErroras the metadata object is frozen.