feat(core): MsgCallback is now typed as returning `void | Promise<nev…

…er>` to indicate that they cannot contain `await` (#202) Signed-off-by: Alberto Ricart <[email protected]>
nats-io · Feb 4, 2025 · 3d448c9 · 3d448c9
1 parent 6a0a9b7
commit 3d448c9
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 7 deletions.
diff --git a/core/src/core.ts b/core/src/core.ts
@@ -77,7 +77,10 @@ export type Status =
   | SlowConsumerStatus
   | ForceReconnectStatus;
 
-export type MsgCallback<T> = (err: Error | null, msg: T) => void;
+export type MsgCallback<T> = (
+  err: Error | null,
+  msg: T,
+) => void | Promise<never>;
 
 /**
  * Subscription Options

diff --git a/core/tests/basics_test.ts b/core/tests/basics_test.ts
@@ -1181,9 +1181,8 @@ Deno.test("basics - request many waits for timer late response", async () => {
 
   const subj = createInbox();
   nc.subscribe(subj, {
-    callback: async (_err, msg) => {
-      await delay(1750);
-      msg.respond();
+    callback: (_err, msg) => {
+      delay(1759).then(() => msg.respond());
     },
   });
 

diff --git a/core/tests/mrequest_test.ts b/core/tests/mrequest_test.ts
@@ -204,9 +204,10 @@ async function requestTimerLateResponse(noMux = false): Promise<void> {
 
   const subj = createInbox();
   nc.subscribe(subj, {
-    callback: async (_err, msg) => {
-      await delay(1750);
-      msg.respond();
+    callback: (_err, msg) => {
+      delay(1750).then(() => {
+        msg.respond();
+      });
     },
   });