Skip to content

[IMPROVED] De-flake TestHotSpotReconnect and fix kv per key TTL test#1926

Merged
piotrpio merged 2 commits intomainfrom
fix-hotspot-reconnect-test
Aug 22, 2025
Merged

[IMPROVED] De-flake TestHotSpotReconnect and fix kv per key TTL test#1926
piotrpio merged 2 commits intomainfrom
fix-hotspot-reconnect-test

Conversation

@piotrpio
Copy link
Copy Markdown
Collaborator

@piotrpio piotrpio commented Aug 21, 2025

Signed-off-by: Piotr Piotrowski piotr@synadia.com

Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
@coveralls
Copy link
Copy Markdown

coveralls commented Aug 21, 2025

Coverage Status

coverage: 84.943% (-0.006%) from 84.949%
when pulling a09d132 on fix-hotspot-reconnect-test
into 0ed8647 on main.

Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
@piotrpio piotrpio changed the title [IMPROVED] De-flake TestHotSpotReconnect [IMPROVED] De-flake TestHotSpotReconnect and fix kv per key TTL test Aug 22, 2025
@piotrpio piotrpio requested review from Jarema and Copilot August 22, 2025 13:08
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves test stability by de-flaking the TestHotSpotReconnect test and fixing a KV per-key TTL test that was broken due to server behavior changes.

  • Increased acceptable client connection variance from 40% to 50% in TestHotSpotReconnect
  • Removed obsolete test code checking for marker existence after purge in TestKeyValueLimitMarkerTTL
  • Updated various dependencies to newer versions in test modules

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
test/cluster_test.go Increased tolerance threshold for client distribution to reduce test flakiness
jetstream/test/kv_test.go Removed test code that checked for markers after purge, which is no longer valid behavior
go_test.mod Updated dependency versions including nats-server and other packages
go_test.sum Updated checksums for dependency version changes

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Copy Markdown
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piotrpio piotrpio merged commit 3d824b0 into main Aug 22, 2025
7 checks passed
@piotrpio piotrpio deleted the fix-hotspot-reconnect-test branch August 22, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants