[IMPROVED] De-flake TestHotSpotReconnect and fix kv per key TTL test#1926
Merged
[IMPROVED] De-flake TestHotSpotReconnect and fix kv per key TTL test#1926
Conversation
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves test stability by de-flaking the TestHotSpotReconnect test and fixing a KV per-key TTL test that was broken due to server behavior changes.
- Increased acceptable client connection variance from 40% to 50% in TestHotSpotReconnect
- Removed obsolete test code checking for marker existence after purge in TestKeyValueLimitMarkerTTL
- Updated various dependencies to newer versions in test modules
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/cluster_test.go | Increased tolerance threshold for client distribution to reduce test flakiness |
| jetstream/test/kv_test.go | Removed test code that checked for markers after purge, which is no longer valid behavior |
| go_test.mod | Updated dependency versions including nats-server and other packages |
| go_test.sum | Updated checksums for dependency version changes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Piotr Piotrowski piotr@synadia.com