[ADDED] KeyValue per key TTL support and limit markers - #1864
Merged
Conversation
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
piotrpio
marked this pull request as ready for review
April 28, 2025 08:39
Jarema
requested changes
Apr 29, 2025
| case kvpurge: | ||
| op = KeyValuePurge | ||
| } | ||
| } else if m.Header.Get(MarkerReasonHeader) != "" { |
Member
There was a problem hiding this comment.
are we 100% sure we should treat those the same as headers?
Collaborator
Author
There was a problem hiding this comment.
I was following ADR here: https://github.com/nats-io/nats-architecture-and-design/blob/main/adr/ADR-48.md#retrieving-values
But I think that makes sense, this marks the same set of KV operations, only different mechanisms.
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added:
LimitMarkerTTLconfig option to enable automatic tombstone deletion.KeyTTLoption tokv.Create()PurgeTTLoption tokv.Purge()Signed-off-by: Piotr Piotrowski piotr@synadia.com