[IMPROVED] Stop the watcher before performing the purge operations for PurgeDeletes. - #1839
Merged
Conversation
…tes. This is to avoid the server having to keep calculating numPending for the watcher itself. This can be especially penal if we purge more than one message and the stream / KV has a lot of keys. The server will also be improved in handling this situation, those changes are in flight. Signed-off-by: Derek Collison <derek@nats.io>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to avoid the server having to keep calculating numPending for the watcher itself. This can be especially penal if we purge more than one message and the stream / KV has a lot of keys. The server will also be improved in handling this situation, those changes are in flight.
Signed-off-by: Derek Collison derek@nats.io