Skip to content

[FIXED] Ordered consumer not restarting on no responders - #1827

Merged
piotrpio merged 2 commits into
mainfrom
fix-no-responders
Mar 19, 2025
Merged

[FIXED] Ordered consumer not restarting on no responders#1827
piotrpio merged 2 commits into
mainfrom
fix-no-responders

Conversation

@piotrpio

Copy link
Copy Markdown
Collaborator

Since v2.10.26, server sends "no responders" for API calls which previously would time out. This PR fixes an issue where an ordered consumer would not be recreated on "no responders" and fixes tests which were using the previous server behavior to test for missing heartbeats.

Signed-off-by: Piotr Piotrowski piotr@synadia.com

Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
@piotrpio
piotrpio requested a review from Jarema March 19, 2025 14:41
@Jarema Jarema changed the title [FIXED] Ordered consumer not restarting on no responcers [FIXED] Ordered consumer not restarting on no responders Mar 19, 2025

@Jarema Jarema left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just one typo.

Comment thread test/js_test.go Outdated
@coveralls

coveralls commented Mar 19, 2025

Copy link
Copy Markdown

Coverage Status

coverage: 84.484% (-0.4%) from 84.855%
when pulling cf218d5 on fix-no-responders
into 0f6e9ef on main.

Co-authored-by: Tomasz Pietrek <tomasz@nats.io>
@piotrpio
piotrpio merged commit 8e5c8b8 into main Mar 19, 2025
@piotrpio
piotrpio deleted the fix-no-responders branch March 19, 2025 15:06
@piotrpio piotrpio mentioned this pull request Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants