fix: use resp.Error to show NATS error in deleteMsg#1822
Merged
piotrpio merged 1 commit intoMar 19, 2025
Conversation
The error message in deleteMsg was printing nil when resp.Success was false. Changed to use resp.Error, displaying the actual NATS error.
imariman
force-pushed
the
fix-jetstream-deletemsg-error-message
branch
from
March 15, 2025 10:52
a0db27b to
4f5980d
Compare
piotrpio
approved these changes
Mar 19, 2025
piotrpio
left a comment
piotrpio
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! Thank you for the contribution!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error message in deleteMsg was printing nil when resp.Success was false. Changed to use resp.Error, displaying the actual NATS error.