Skip to content

Added support for KV mirrors and sources.#1112

Merged
derekcollison merged 1 commit into
mainfrom
kv-mirrors
Oct 20, 2022
Merged

Added support for KV mirrors and sources.#1112
derekcollison merged 1 commit into
mainfrom
kv-mirrors

Conversation

@derekcollison

Copy link
Copy Markdown
Member

Also updated state for proper Put() and Get() semantics with mirrors and across domains, e.g. leafnodes.

In practice when a mirror is across a domain, should be named the same as origin. That allows an app to run anywhere without anything special in terms of domains when binding to the KV itself.

Signed-off-by: Derek Collison derek@nats.io

… Put() and Get() with mirrors and across domains, e.g. leafnodes.

Signed-off-by: Derek Collison <derek@nats.io>
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.2%) to 85.751% when pulling 1d9796f on kv-mirrors into 888a91d on main.

@kozlovic kozlovic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread test/kv_test.go

_, err = kv.PutString("name", "derek")
expectOk(t, err)
_, err = kv.PutString("age", "22")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you wish ;-)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants