Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kv): fixed an issue where kv sources were not properly processed #721

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

aricart
Copy link
Member

@aricart aricart commented Jul 29, 2024

  • added a required transform to the source
  • added the kv subject when sources are present

Copy link

@jnmoyne jnmoyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart merged commit 577b811 into main Jul 29, 2024
5 checks passed
aricart added a commit to nats-io/nats.js that referenced this pull request Jul 29, 2024
…lidating stream sources

fix(kv): fixed handling of kv sources by adding a necessary transform

--
This fix was ported from nats-io/nats.deno#721
aricart added a commit to nats-io/nats.js that referenced this pull request Jul 30, 2024
fix(jetstream): fixed possible dereference of undefined value when validating stream sources

fix(kv): fixed handling of kv sources by adding a necessary transform

--
This fix was ported from nats-io/nats.deno#721
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants