Map opts.replicas to sc.num_replicas in Object Store init
#717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aricart
approved these changes
Jul 24, 2024
|
@SalvaChiLlo thank you for spotting this. |
aricart
added a commit
that referenced
this pull request
Jul 24, 2024
aricart
added a commit
that referenced
this pull request
Jul 24, 2024
[TEST] added test to cover fix for #717
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library interface, defined by the
ObjectStoreOptionstype, currently expects a parameter namedreplicasto specify the number of replicas for the object store. However, internally, the correct parameter to be used isnum_replicas. To align with the existing initialization method of KV, the initialization method of OB should also mapopts.replicastosc.num_replicas. This ensures consistency and proper utilization of thereplicasparameter within the object store configuration.