Early PONG rejection #390
Merged
Early PONG rejection #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in some difficult scenarios in node for the pong to be rejected before other handlers are setup. See https://github.com/nats-io/nats.js/issues/523 [LINT] fixed some linter and fmt warnings
ArmorDarks
reviewed
Oct 25, 2022
| @@ -217,6 +217,9 @@ export class ProtocolHandler implements Dispatcher<ParserEvent> { | |||
| this.resetOutbound(); | |||
|
|
|||
| const pong = deferred<void>(); | |||
| pong.catch(() => { | |||
| // provide at least one catch - as pong rejection can happen before it is expected | |||
There was a problem hiding this comment.
How about a log warning about such errors, or better make it properly awaited? There's no guarantee that it will always fail with an "ok" error. If some exception happens, it will be swallowed here, which will make debugging quite a challenge
…nect error when it closed the client.
|
Added some additional guardrails, depending on the runtime the type of error returned will be different. But in cases where the client was telegraphing the PONG rejection, the disconnect error will not have a trace, as that trace is bogus, the client simply disconnected. With that said in node, the errors are properly reported now, but that is a different PR. |
This was referenced Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FIX] added a catch to the initial pong promise as it seems possible in some difficult scenarios in node for the pong to be rejected before other handlers are setup. See https://github.com/nats-io/nats.js/issues/523
[LINT] fixed some linter and fmt warnings