Ordered consumer changes #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
kozlovic
reviewed
Sep 29, 2022
aricart
commented
Sep 29, 2022
nats-base-client/jsclient.ts
Outdated
| return false; | ||
| } | ||
| // reset the consumer | ||
| const seq = this.info?.ordered_consumer_sequence?.delivery_seq; |
There was a problem hiding this comment.
this is possibly not right either - the sequence if we have one, should be incremeted
kozlovic
suggested changes
Sep 29, 2022
nats-base-client/jsclient.ts
Outdated
| return false; | ||
| } | ||
| // reset the consumer | ||
| const seq = this.info?.ordered_consumer_sequence?.delivery_seq || 0; |
There was a problem hiding this comment.
The sequence needs to be the stream sequence, not the consumer sequence.
There was a problem hiding this comment.
That is, the library needs to keep track of the stream sequence in the message's reply (the meta data) and when resetting, need to reset at that sequence + 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[CHANGE] [JS] ordered consumers now default to memory storage and no replicas
[CHANGE] [JS] ordered consumers now recreate the consumer if heartbeats are missed. Note that the client will not get a notification since the client will try to recover. This is also a change for iterators since the ordered consumer iterator will now resume when the consumer
is recreated. For non-ordered consumers, any error will be notified on the callback until the subcription ends. Iterator based consumers will stop with the missed heartbeat error.
[FIX] [JS] publishing retries now properly handle timeouts
FIX #375