Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] [TEST] cross account test environment to allow acks to cross #374

Merged
merged 2 commits into from
Sep 28, 2022
Merged

[FIX] [TEST] cross account test environment to allow acks to cross #374

merged 2 commits into from
Sep 28, 2022

Conversation

aricart
Copy link
Member

@aricart aricart commented Sep 28, 2022

No description provided.

@aricart aricart requested a review from kozlovic September 28, 2022 18:43
kozlovic
kozlovic approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/jetstream_test.ts Outdated Show resolved Hide resolved
@aricart aricart temporarily deployed to CI September 28, 2022 20:24 Inactive
kozlovic
kozlovic approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart merged commit 8426af1 into main Sep 28, 2022
@aricart aricart deleted the xaccount-ack branch September 28, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kozlovic kozlovic kozlovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aricart @kozlovic