Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] [OS] made put() reject link configurations #367

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Conversation

aricart
Copy link
Member

@aricart aricart commented Sep 19, 2022

Link configurations must be routed through the link() API. This matches changes made to the go client in https://github.com/nats-io/nats.go/pull/1057/files

@aricart aricart requested a review from kozlovic September 19, 2022 15:35
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart temporarily deployed to CI September 19, 2022 18:49 Inactive
@aricart aricart merged commit d85bbf5 into main Sep 19, 2022
@aricart aricart deleted the os-no-put-link branch September 19, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants