Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature disablements #366

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Feature disablements #366

merged 1 commit into from
Sep 16, 2022

Conversation

aricart
Copy link
Member

@aricart aricart commented Sep 16, 2022

[FEAT] added mechanism where a Feature can be disabled by the user. This requires casting the connection to a NatsConnectionImpl, and then accessing the Features controller as nc.features.disable(Feature). This is an experimental feature, currently supporting a very small number of options

… This requires casting the connection to a `NatsConnectionImpl`, and then accessing the `Features` controller as `nc.features.disable(Feature)`. This is an experimental feature, currently supporting a very small number of options
@aricart aricart requested a review from kozlovic September 16, 2022 19:58
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart merged commit 177c3da into main Sep 16, 2022
@aricart aricart deleted the feature-disable branch September 16, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants