Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] StreamInfo pagination support #365

Merged
merged 3 commits into from
Sep 16, 2022
Merged

[FEAT] StreamInfo pagination support #365

merged 3 commits into from
Sep 16, 2022

Conversation

aricart
Copy link
Member

@aricart aricart commented Sep 16, 2022

[FEAT] added internal pagination to jsm.streams.info(), if required, the call will collect the necessary pages and merge subjects. StreamInfoRequestOptions now also has support for ApiPagedRequest.

[FIX] Lister interface was missing Symbol.asyncIterator, so it couldn't be used directly as intended.

@aricart aricart requested a review from kozlovic September 16, 2022 19:07
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…, the call will collect the necessary pages and merge the subjects information. `StreamInfoRequestOptions` now also has support for `ApiPagedRequest`.

[FIX] `Lister` interface was missing `Symbol.asyncIterator` so it couldn't be used directly as intended.
@aricart aricart temporarily deployed to CI September 16, 2022 20:31 Inactive
@aricart aricart merged commit 1d1cc6e into main Sep 16, 2022
@aricart aricart deleted the pagination branch September 16, 2022 20:41
@aricart aricart changed the title StreamInfo pagination support [FEAT] StreamInfo pagination support Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants