Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] name of the consumer was not captured when binding to an ephemeral #330

Merged
merged 1 commit into from
Jul 13, 2022
Merged

[FIX] name of the consumer was not captured when binding to an ephemeral #330

merged 1 commit into from
Jul 13, 2022

Conversation

aricart
Copy link
Member

@aricart aricart commented Jul 13, 2022

This has the effect of failing consumerInfo() on the subscription

FIX #329

@aricart aricart requested a review from kozlovic July 13, 2022 14:16
kozlovic
kozlovic approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart merged commit eacbc3b into main Jul 13, 2022
@aricart aricart deleted the fix-329 branch August 22, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kozlovic kozlovic kozlovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sub.consumerInfo() doesn't work for ephemerals
2 participants
@aricart @kozlovic