[FEAT] [EXPERIMENTAL] added support for next_by_subj to direct stream api #325
Conversation
[REFACTOR] moved direct API to its own JSM api class
nats-base-client/jsmdirect_api.ts
Outdated
| } | ||
|
|
||
| get lastSequence(): number { | ||
| const v = this.header.get(RepublishedHeaders.JsLastSequence); |
There was a problem hiding this comment.
I am not seeing that being set by the server. Where would that come from?
There was a problem hiding this comment.
very good catch - this was related to the RepublishedMessageHeaders which is not what this PR is about.
…ce to `Nats-Last-Sequence` as this is a Republished Message Header.
| */ | ||
| export type NextMsgRequest = { | ||
| seq: number; | ||
| next_by_subj: string; |
There was a problem hiding this comment.
I think that NextMsgRequest should also have last_by_subj, which corresponds to the enum below to "LastForMsgRequest"?
There was a problem hiding this comment.
It does, the argument that you can provide for getMessage as a DirectMsgRequest which is an alias for one of three types LastForMsgRequest is one of the possible values:
export type DirectMsgRequest =
| SeqMsgRequest
| LastForMsgRequest
| NextMsgRequest;
| next_by_subj: string; | ||
| }; | ||
|
|
||
| export type DirectMsgRequest = |
There was a problem hiding this comment.
Not sure what this is for though... looking at the example below, you are creating the request manually and pass last_by_subj (which is missing in the exported NextMsgRequest object above)..
There was a problem hiding this comment.
The API returns a StoredMsg which is an interface (same as what you can $JS.API.STREAM.MSG.GET.${stream}. In TypeScript this is typed, as you cannot ack or do anything with these messages.
There was a problem hiding this comment.
(typescript is just looking for a type that has the fields defined by the type) it is not cast/it is just something that has that 'shape'.
There was a problem hiding this comment.
We followed up on a call and it is clear to me now.
[REFACTOR] moved direct API to its own JSM api class