Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support ConsumerConfiguration backoff #300

Merged
merged 2 commits into from
May 16, 2022
Merged

support ConsumerConfiguration backoff #300

merged 2 commits into from
May 16, 2022

Conversation

aricart
Copy link
Member

@aricart aricart commented May 16, 2022

[FEAT] support ConsumerConfiguration backoff - a list of nanos which changes the behaviour of ack_wait to match the list provided in backoff

FIX #299

aricart added 2 commits May 16, 2022 14:15
…h changes the behaviour of ack_wait to match the list provided in backoff

FIX #299
@aricart aricart temporarily deployed to CI May 16, 2022 19:17 Inactive
@aricart aricart requested a review from kozlovic May 16, 2022 19:17
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

const { stream, subj } = await initStream(nc);
const jsm = await nc.jetstreamManager();

const backoff = [nanos(250), nanos(1000), nanos(3000)];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Not sure if nanos() is "yours", but it would have been better to name this something like: milliseconds_to_nanos().

@aricart aricart merged commit a148e7e into main May 16, 2022
@aricart aricart deleted the backoff branch May 16, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support consumer configuration backoff
2 participants