Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose permission errors at the request api level #296

Merged
merged 2 commits into from
May 13, 2022
Merged

Expose permission errors at the request api level #296

merged 2 commits into from
May 13, 2022

Conversation

aricart
Copy link
Member

@aricart aricart commented May 13, 2022

[FEAT] request api only rejects responses due to timeouts or no responders, but in the case of permissions, the client may not be able to publish to the request subject or subscribe to the mux inbox, this change rejects the request providing a more context relevant error. Previously it was only possible to learn about the error via the async error notification.

FIX #266

…nders, but in the case of permissions, the client may not be able to publish to the request subject or subscribe to the mux inbox, this change rejects the request providing a more context relevant error. Previously it was only possible to learn about the error due to the async error notification.

FIX #266
@aricart aricart requested a review from kozlovic May 13, 2022 18:20
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…it so that it is possible to resub should permssions change
@aricart aricart temporarily deployed to CI May 13, 2022 20:15 Inactive
@aricart aricart merged commit bad50bf into main May 13, 2022
@aricart aricart deleted the fix-266 branch May 13, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

request error enhancement
2 participants