Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] updated StreamInfo to report alternates #291

Merged
merged 2 commits into from
May 11, 2022
Merged

[FEAT] updated StreamInfo to report alternates #291

merged 2 commits into from
May 11, 2022

Conversation

aricart
Copy link
Member

@aricart aricart commented May 10, 2022

No description provided.

@aricart aricart requested a review from kozlovic May 10, 2022 15:55
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but see comment about server version.


const n = await jsm1.streams.find("A");
const si = await jsm1.streams.info(n);
assertEquals(si.alternates?.length, 2);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably need to assert the server version at top of test? I think this is available only since a recent release of the server.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIXED

@aricart aricart temporarily deployed to CI May 11, 2022 15:24 Inactive
@aricart aricart merged commit 9383def into main May 11, 2022
@aricart aricart deleted the alternates branch May 11, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants