Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible double conversion to nanos #284

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Conversation

aricart
Copy link
Member

@aricart aricart commented Apr 14, 2022

[FIX] JsMsg.next() converted in place the expires options to nanos in-place creating the posibility of encoding a nano value twice.

… place creating the posibility of encoding a nano value twice.
@aricart aricart requested a review from kozlovic April 14, 2022 17:48
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart merged commit 0cdf439 into main Apr 14, 2022
@aricart aricart deleted the fix-in-place-conversion branch April 14, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants