[FEAT] add method to bind to existing KVs #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aricart
requested changes
Mar 29, 2022
nats-base-client/jsclient.ts
Outdated
| @@ -92,6 +93,9 @@ class ViewsImpl implements Views { | |||
| kv(name: string, opts: Partial<KvOptions> = {}): Promise<KV> { | |||
| return Bucket.create(this.js, name, opts); | |||
| } | |||
| bind(name: string, codec?: KvCodecs): Promise<KV> { | |||
There was a problem hiding this comment.
this needs to be triggered by an option in KvOptions. - the views interface should simply be the raw functionality - kv, object store, etc.
There was a problem hiding this comment.
@aricart so basically additional "bind" option in KvOptions?
There was a problem hiding this comment.
fixed.
went with bindOnly as thats more self-explenatory and clear IMO.
aricart
requested changes
Mar 29, 2022
nats-base-client/kv.ts
Outdated
| static async bind( | ||
| js: JetStreamClient, | ||
| name: string, | ||
| codec: KvCodecs = NoopKvCodecs(), |
There was a problem hiding this comment.
make the sig (js: JetStreamClient, name: string, opts: {codec: KvCodec} = {})
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method allows binding to existing KV without creating it.