[FIX] when specifying a bind, if the consumer didn't specify deliver_to get flagged as pull #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to, it was trapped as being a pull consumer, when the expected is that it will be what the bind returns.
Jarema
requested changes
Mar 4, 2022
nats-base-client/jsclient.ts
Outdated
| @@ -330,7 +330,7 @@ export class JetStreamClientImpl extends BaseApiClient | |||
| const cso = await this._processOptions(subject, opts); | |||
| // this effectively requires deliver subject to be specified | |||
| // as an option otherwise we have a pull consumer | |||
| if (!cso.config.deliver_subject) { | |||
| if (!cso.isBind && !cso.config.deliver_subject) { | |||
| throw new Error( | |||
| "consumer info specifies a pull consumer - deliver_subject is required", | |||
There was a problem hiding this comment.
Suggested change
| "consumer info specifies a pull consumer - deliver_subject is required", | |
| "deliver_subject is required for Push Consumer", |
…eliver_subject to `push consumer requires deliver_subject` [CHORE] removed debug test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.