Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] surface JS errors as per ADR-7 #227

Merged
merged 2 commits into from
Nov 11, 2021
Merged

[FEAT] surface JS errors as per ADR-7 #227

merged 2 commits into from
Nov 11, 2021

Conversation

aricart
Copy link
Member

@aricart aricart commented Nov 11, 2021

The modification enhances NatsError by adding:

isJetStreamError(): boolean
jsError(): ApiError|null

This enables clients to test if there's more info to the underlying error

FIX #226

The modification enhances NatsError by adding:

`isJetStreamError(): boolean`
`jsError(): ApiError|null`

This enables clients to test if there's more info to the underlying error

FIX #226
@aricart aricart requested a review from kozlovic November 11, 2021 00:09
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart temporarily deployed to CI November 11, 2021 20:42 Inactive
@aricart aricart temporarily deployed to CI November 11, 2021 20:42 Inactive
@aricart aricart temporarily deployed to CI November 11, 2021 20:42 Inactive
@aricart aricart merged commit e929b06 into main Nov 11, 2021
@aricart aricart deleted the fix-226 branch November 11, 2021 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide detailed error details in exceptions
2 participants