Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposed newly added consumer/stream options #211

Merged
merged 2 commits into from
Oct 19, 2021
Merged

Conversation

aricart
Copy link
Member

@aricart aricart commented Oct 18, 2021

[FEAT] enhanced ConsumerOptsBuilder to expose same options as Go implementation

[FEAT] exposed support for stream options sealed, deny_delete, deny_purge, allow_rollup_hdrs

[FEAT] rollup can be configured by setting the header JsHeaders.RollupHdr with a value JsHeaders.RollupValueSubject or JsHeaders.RollupValueAll.

[FEAT] exposed ConsumerConfig.headers_only - enabling a consumer to retrieve messages without including the payload. To see the size of the payload, inspect the JsHeaders.MessageSizeHdr.

…ementation

[FEAT] exposed support for stream options `sealed`, `deny_delete`, `deny_purge`, `allow_rollup_hdrs`
[FEAT] rollup can be configured by setting the header `JsHeaders.RollupHdr` with a value `JsHeaders.RollupValueSubject` or `JsHeaders.RollupValueAll`.
[FEAT] exposed `ConsumerConfig.headers_only` - enabling a consumer to retrieve messages without including the payload. To see the size of the payload, inspect the `JsHeaders.MessageSizeHdr`.
@aricart aricart temporarily deployed to CI October 18, 2021 22:01 Inactive
@aricart aricart temporarily deployed to CI October 18, 2021 22:01 Inactive
@aricart aricart temporarily deployed to CI October 18, 2021 22:01 Inactive
Copy link

@matthiashanel matthiashanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basically ok with that. just two comments.

@aricart aricart temporarily deployed to CI October 19, 2021 14:07 Inactive
@aricart aricart temporarily deployed to CI October 19, 2021 14:07 Inactive
@aricart aricart temporarily deployed to CI October 19, 2021 14:07 Inactive
@aricart aricart merged commit f68fed5 into main Oct 19, 2021
@aricart aricart deleted the consumer-stream-options branch October 19, 2021 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants