Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better trace on timeout #196

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Better trace on timeout #196

merged 1 commit into from
Sep 13, 2021

Conversation

aricart
Copy link
Member

@aricart aricart commented Sep 13, 2021

changed timeout to pre-generate a stack - in the case of a timeout, the stack will have a context to the operation that failed

…he stack will have a context to the operation that failed
@aricart aricart requested a review from kozlovic September 13, 2021 19:47
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart merged commit abde62c into main Sep 13, 2021
@aricart aricart deleted the timeout-trace branch September 13, 2021 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants