Skip to content

Fixed SSLHandshakeTimeout test to prevent flapping#910

Merged
kozlovic merged 1 commit into
mainfrom
fix_ssl_test
Sep 12, 2025
Merged

Fixed SSLHandshakeTimeout test to prevent flapping#910
kozlovic merged 1 commit into
mainfrom
fix_ssl_test

Conversation

@kozlovic

Copy link
Copy Markdown
Member

Strengthen the test added in PR #907. Also improved the error returned during a SSL handshake failure.

Relates to #907

Signed-off-by: Ivan Kozlovic ivan@synadia.com

Strengthen the test added in PR #907. Also improved the error returned
during a SSL handshake failure.

Relates to #907

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
@codecov

codecov Bot commented Sep 12, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.21%. Comparing base (5e99d1f) to head (1d49b80).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #910      +/-   ##
==========================================
+ Coverage   70.18%   70.21%   +0.02%     
==========================================
  Files          48       48              
  Lines       17243    17243              
  Branches     3540     3540              
==========================================
+ Hits        12102    12107       +5     
+ Misses       1737     1730       -7     
- Partials     3404     3406       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kozlovic
kozlovic requested a review from mtmk September 12, 2025 01:55

@mtmk mtmk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread README.md
@kozlovic
kozlovic merged commit 78da030 into main Sep 12, 2025
28 checks passed
@kozlovic
kozlovic deleted the fix_ssl_test branch September 12, 2025 13:49
github-actions Bot pushed a commit that referenced this pull request Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants