Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] SEGFAULT in js_Subscribe if consumer Name is NULL #696

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

levb
Copy link
Collaborator

@levb levb commented Nov 16, 2023

Fixes #695

@levb levb requested a review from mtmk November 16, 2023 09:31
@@ -2656,7 +2656,10 @@ _subscribe(natsSubscription **new_sub, jsCtx *js, const char *subject, const cha
// set only if jsi->consumer is NULL!
if (jsi->consumer == NULL)
{
DUP_STRING(s, jsi->consumer, info->Name);
if (info->Name != NULL)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But why name would be NULL? It should be set no? I am not sure if just doing that here does not move the problem to some other place.

if (info->Name != NULL)
{
DUP_STRING(s, jsi->consumer, info->Name);
}
if (s == NATS_OK)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this PR, but I wonder if I should not have done the rest of that code for pull consumers only...

@levb levb added the stale This issue has had no activity in a while label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale This issue has had no activity in a while
Projects
None yet
Development

Successfully merging this pull request may close these issues.

segfault when calling js_Subscribe for an ephemeral subscription
2 participants