[FIXED] LDM results in max connections exceeded errors#7527
Merged
neilalexander merged 1 commit intomainfrom Nov 7, 2025
Merged
[FIXED] LDM results in max connections exceeded errors#7527neilalexander merged 1 commit intomainfrom
neilalexander merged 1 commit intomainfrom
Conversation
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
This was referenced Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An account using the maximum connections setting means that particular account can only have N connections connected at the same time. A server going into "Lame Duck Mode" will slowly start forcing clients to reconnect to other servers. However, these closed connections would not be deducted from counting against the account limit. Every reconnected client would be counted twice during the LDM duration. If the amount of connections was close to the limit, lots of connections that weren't reconnected yet would instead receive the
maximum account active connections exceedederror.This PR fixes this condition by continuing to do the full accounting, even while LDM is active. Only if the server is shutting down with
s.Shutdown()will it close any remaining clients without needing to do the accounting.Signed-off-by: Maurice van Veen github@mauricevanveen.com